p5-Text-Xslate icon indicating copy to clipboard operation
p5-Text-Xslate copied to clipboard

wishlist: moving from Mouse to Moo

Open ghost opened this issue 11 years ago • 15 comments

Are you planning to move from Mouse to Moo?

ghost avatar Oct 31 '13 14:10 ghost

I have no plan to move to Moo.

Why do you recommend a slower module?

gfx avatar Oct 31 '13 15:10 gfx

maybe use p5mop if it should ever become faster than Mouse :)

at least, most of the module is now written in xs, but still alpha software

https://github.com/stevan/p5-mop-redux

forwardever avatar Oct 31 '13 20:10 forwardever

p5mop still has a long way to go before it begins to approach the speed of Mouse (the goal is to get there eventually, but that's still a ways off).

doy avatar Oct 31 '13 20:10 doy

I don't hesitate to move to p5mop in a future, but for now it requires Perl 5.16.0 so I can't use it for Xslate.

gfx avatar Nov 01 '13 03:11 gfx

I'd also prefer Moo over Mouse as the former is already in my (quite big) stack of CPAN modules and the later isn't.

abraxxa avatar Feb 05 '14 18:02 abraxxa

While I personally prefer to use Moo most of the time, Mouse(::XS) is much faster and speed is most of the attraction for me in Xslate. So Moo-- here.

pangyre avatar Feb 05 '14 18:02 pangyre

After an "interesting" week-end spent at work over the "fatal warnings" switch, I'd rather have Text::Xslate stick to Mouse.

GeJ avatar Feb 05 '14 22:02 GeJ

If I stop using Mouse I prefer to use plain old Perl objects instead of any other OOP framework, but currently I have no time to make such a refactoring anyway.

I'm willing to review patches which drop dependencies on Mouse.

gfx avatar Feb 05 '14 22:02 gfx

Have you considered Moo with Class::XSAccessor?

xsawyerx avatar Feb 05 '14 23:02 xsawyerx

I think use of plain perl objects is preferable. Mouse dependency creates additional overhead in projects, where Moo or Moose used. As i see in sources - Mouse used only in few classes, so porting to perl object would be easy.

zdm avatar Aug 25 '14 12:08 zdm

Use of plain perl objects looks the best solution that I, if any, should make. I hope someone make a pull request about it.

gfx avatar Aug 25 '14 14:08 gfx

@gfx++

xsawyerx avatar Aug 26 '14 04:08 xsawyerx

Also it maybe useful to switch to JSON::XS instead of Data::MessagePack, because JSON::XS is approximately 4 times faster.

zdm avatar Sep 19 '14 14:09 zdm

As usual YMMV, but with a quick Benchmark script, I found DM to be ~70% faster than JSON::XS when serializing, and ~40% faster when deserializing. I'd rather have DM stay.

GeJ avatar Sep 20 '14 04:09 GeJ

Is the plan to remove the dependency on Mouse still alive?

abraxxa avatar Sep 07 '17 11:09 abraxxa