xeps icon indicating copy to clipboard operation
xeps copied to clipboard

XEP-0176 data type of ICE `foundation`

Open xdumaine opened this issue 7 years ago • 6 comments

Jingle ICE defines the "foundation" of it's ICE candidate as an unsigned byte in it's schema: https://xmpp.org/extensions/xep-0176.html#schema which does not seem to match the ICE RFC which defines it as a string: https://tools.ietf.org/html/rfc5245#section-15.1

XEP-0176 should change the type foundation string with valid chars A-z, 0-9, +, /

@legastero @fippo @stpeter

xdumaine avatar Jan 19 '18 13:01 xdumaine

see https://xmpp.org/extensions/xep-0371.html#protocol-syntax -- we fixed this there.

fippo avatar Jan 19 '18 15:01 fippo

So it's just a matter of fixing the schema, replacing

        <xs:attribute name='foundation' type='xs:unsignedByte' use='required'/>

with

        <xs:attribute name='foundation' type='xs:string use='required'/>

?

Flowdalic avatar Jan 19 '18 15:01 Flowdalic

@Flowdalic there is a bigger issue. 0176 was written against a pre-RFC version of ICE which was in limbo for half a decade before it became RFC 5245

fippo avatar Jan 19 '18 15:01 fippo

We really should deprecate XEP-0176 and advance XEP-0371. I had some non-related fixes in process but lost track of this work item a few years ago. :(

stpeter avatar Jan 19 '18 17:01 stpeter

we made notes in the wiki page...

fippo avatar Jan 19 '18 17:01 fippo

Yeah, but finding the time and energy to work on it is not so easy. :-) I will try to find my edits this weekend (unfortunately they were to the entire Jingle suite so it was a big changeset).

stpeter avatar Jan 19 '18 17:01 stpeter