xs5871

Results 118 comments of xs5871

Sure, let's get it in as an intermediate solution and maybe revisit once #430 is merged. But: the script is something I would consider a 3d-party tool, in the sense...

There are unaddressed change requests and questionable changes.

You're absolutely right. Incidentally that's what I tried first and got tangled up in a terrible, un-working mess, as first implementations go. So I settled for the bare minimum, easyiest...

@klardotsh what's your opinion on this implementation? I'm not used to using type hints in python yet, but it seems like something we may want to insist on for core...

Haven't found any other obvious bugs, I think it's good to go. We may want to take a look at all the other modules that issue key events. Maybe some...

this may help: https://github.com/KMKfw/kmk_firmware/blob/master/docs/boot.md

No, the stack limit should fix _most_ of the pystack exhaust problems, but there are corner cases. We have a PR (#430) in the works that (from my testing) fixes...

In order to keep some atomizity I would categorize that as the next step. It would definitely make it easier to have a transport agnostic report. We should keep that...

Hm. That'll probably be a pain to figure out. Could you provide the debug output when that happens? I opened a PR for more usefull debug information for holdtap.

```python combos.combos = [ Chord((KC.A, KC.B), send_string("PRESSED")), ] ```