httrack icon indicating copy to clipboard operation
httrack copied to clipboard

Fix for handling changes introduced in postprocess

Open RomanSek opened this issue 8 years ago • 2 comments

Plugin postprocessing didn't introduce changes in files if string chain pointer didn't change. I removed additional check for that so HTTrack will now depend only on return value from plugin to apply changes. Let me know if you need tests for this fix.

RomanSek avatar May 04 '17 13:05 RomanSek

I don't get the change - if cAddr == TypedArrayElts(output_buffer), the copy will be idem-potent, so this does not change anything

xroche avatar Jun 10 '18 11:06 xroche

I'm a bit rusty with my C, so I can be wrong. I suspect that bug happens when you realloc memory for changed output and get pointer to the same memory address, but with bigger/smaller size of the allocated memory block. In that case if cAddr == TypedArrayElts(output_buffer) will be true, but new output is different and isn't copied properly.

If you want - I can write a plugin that triggers this behavior.

RomanSek avatar Jun 11 '18 09:06 RomanSek