Xavier Roblot

Results 28 comments of Xavier Roblot

Could you please merge with master to solve the conflict. Eventually, this PR will move up the PR queue and will get a review but it needs to be without...

Right, sorry. I got confused. I'll change the tag to `WIP` on this PR then to avoid any further confusion.

Yeah, I agree with that. I'll change this one to WIP and the other one to awaiting-review.

~~I changed this back to WIP because I think I might need to change a bit the definition of the fundamental cone.~~

@riccardobrasca, this file is getting a bit long. Do you prefer that I break it into smaller PRs?

> > @riccardobrasca, this file is getting a bit long. Do you prefer that I break it into smaller PRs? > > If you can yes. Feel free to ask...

> Part of this is PR is also in #18234, right? Sorry. I forgot to finish cleaning up before removing WIP. Let me put it back for the time being....

> Can you please fix the error? Yes, I haven't updated this PR for quite some time, so it might take a bit to get it ready for review.