Riccardo Magliocchetti

Results 454 comments of Riccardo Magliocchetti

That's strange, `__all__` specifies the stuff you can import with `*` not what is exported https://docs.python.org/3/tutorial/modules.html#importing-from-a-package

> I did not add or remove any public symbols so I have no clue why that test is failing. Could someone help me with this? I think you get...

> > I guess we are missing a test for the behaviour, like asserting we are not serializing the fields if it is 0 > > Would you like me...

> I don't think any of the contrib issues are strictly needed for stabilization. We should address [#4330](https://github.com/open-telemetry/opentelemetry-python/issues/4330) IMO. Added the LoggingHandler move to the table. I've listed the contrib...

So here's a try at serializing all these PRs: - [x] find some downstream users that may be interested in checking their stuff against OTel git. Do we have big...

In opentelemetry.io we need to take care of the following references, that also means we don't have documentation for LogRecordLimits: ``` content/en/docs/languages/python/instrumentation.md:from opentelemetry.sdk._logs.export import BatchLogRecordProcessor, ConsoleLogExporter content/en/docs/languages/python/instrumentation.md:processor = BatchLogRecordProcessor(ConsoleLogExporter()) content/pt/docs/languages/python/instrumentation.md:from...

1.39.0 contains all the changes to logs API and SDK (including events), 1.40.0 should contain the changes for the logging handler.

The plan was to move all the attributes to the default `OTELResourceDetector` as they are marked stable. In the meantime I think `all` may be a good workaround. Let's see...

> The sdk part LGTM but I think we are missing a test to assert that sometimes these fields are not serialized We need two tests because AFAICS we don't...