Minor details in setup.py regarding FOR loops

[cwgaldino]

This FOR loop seems to be stuck on 'plugins'. I do not know if its a mistake or not. Anyway, you might wanna change line 148 to: fname = pjoin(larchdir, dirname)

https://github.com/xraypy/xraylarch/blob/8de4dd13beb3df716127505bb61b3b4d11694f1e/setup.py#L144-L150

Also, another mirror detail, when you run the FOR loop below larch.bin is already appended to packages and I think it is not necessary to "manually" add it and line 113 may be simplified to packages = ['larch'].

https://github.com/xraypy/xraylarch/blob/8de4dd13beb3df716127505bb61b3b4d11694f1e/setup.py#L113-L115

[newville]

@cwgaldino Thanks! I agree with the second point -- that should be easy to fix.

The first point must mean (I think) that there is some permission problem on installation. Trying to delete files on install should be "willing to fail without problems. But also: I saw a few what might be similar permission issues for users on MacOS last week (XAFS School). I'll look into a better solution for all of those.

Were you installing with the installer on MacOS or some other way?

[cwgaldino]

@newville Thanks for the kick response!

I am not having any trouble installing it. To answer your question, I cloned the repository and installed it from source on linux (Ubuntu 18.04.2 LTS).

For no particular reason I was reading the setup.py file and decided to share those thoughts.

Regarding the first point It just seems that the for loop "wanted" to cycle trough ('plugins', 'dlls', 'icons'), but it is not doing so. You may close the issue if that's by design!