flutter_sparkline
flutter_sparkline copied to clipboard
[Bug] Exact same data produces no graph
If that data List
If you set a fixed _max and _min, this gets fixed.
I'm waiting for the correction of this bug ... can you correct this ?
Same issues please find a solution... I just want a flat line if all my data are [0.0]. Thank you
Hey, this is kinda a major issue :( Any timeline on a fix?
Issues is line 300 final double heightNormalizer = height / (_max - _min);
Can be fixed with a change to final double heightNormalizer = height / max(1,(_max - _min));
IIRC one of my repositories (pc-monitor) has a fixed version of this module. If you give me a day or two I can fork this repo and post the new source.
Thanks I actually saw that after posting. I have made some other changes to so that single value lines also plot to the center of the chart instead of the bottom.
if(_min == _max){
if(_min == 0){
_min = -1;
_max = 1;
} else {
_min = _max/2;
_max = _max*2;
}
}
How does your fix handle that case?
For my project it actually made sense for the line to be at the bottom (null value from API => 0/bottom on graph). Not an issue if you want to start a pull request for the middle line, just maybe include it as a parameter for the graph?
Side note: my code was very hacky and poorly written; would you rather look over my repo and then write your own additional code?
Ah shit. I had a hard drive go bad about 8 months ago, and I seem to have lost the updated repository that contained my fixes; unfortunately, it looks like I also forgot to push my commits to the online repo. I don't remember how I fixed the problem, but here's some pseudo-code to describe what I may have done, based on my comment above:
if all_datapoints in line == 0.0:
let min = 0
let max = 1
or, more relevant to your solution:
if all_datapoints in line == 0.0:
let min = -1
let max = 1
and then update the graph with these new boundaries. Doesn't seem too complicated, it's pretty much the same solution you said earlier.
No worries. Looks like we implemented similar solutions and I expect I will be expanding the functionality for my application.
Thanks again!
Hey, this is kinda a major issue :( Any timeline on a fix?
Issues is line 300
final double heightNormalizer = height / (_max - _min);
Can be fixed with a change to
final double heightNormalizer = height / max(1,(_max - _min));
Hi, I tried this but it didn't work for me. Graph still doesn't plot.
Edit: Apologies it does work. Just forgot to import dart:math. Thanks for the help!