mpegts.js icon indicating copy to clipboard operation
mpegts.js copied to clipboard

AC-3 Codec supported or not? README is misleading

Open jamesst20 opened this issue 1 year ago • 2 comments

Hi,

I am not sure if AC-3 codec is supposed to be supported. There are 2 PRs about it:

https://github.com/xqq/mpegts.js/pull/99 https://github.com/xqq/mpegts.js/pull/103

But then the README says

Screenshot 2024-09-24 at 10 42 55 AM

Versus

Screenshot 2024-09-24 at 10 43 03 AM

----------------------------------------------------

From my testing I am getting the same error as this issue: https://github.com/xqq/mpegts.js/issues/115

But looking at the v1.7.3 release:

Screenshot 2024-09-24 at 10 43 39 AM

The support is supposed to be added but then if you take a look at 97 commits to master since this release

Screenshot 2024-09-24 at 10 45 02 AM

You can see support for EAC-3 was added after release but AC-3 before release but then even trying a building the master branch and testing out I am still getting the same error.

Am I missing something?

Here is a video/audio file for testing purposes. Working perfectly in VLC, no audio in mpegts.js

video-h264-audio-ac3.zip

jamesst20 avatar Sep 24 '24 14:09 jamesst20

Currently, ac-3 / ec-3 audio are supported by Safari (MacOS) / Edge (Windows), not supported by Chrome. mpegts.js using MediaSource Extension, but this API does not support these codecs by Chrome.

monyone avatar Sep 24 '24 15:09 monyone

/ ec-3 audio are supported by Safari (MacOS) / Edge (Windows), not supported by Chrome. mpegts.js using MediaSource Extension, but this API does not support these codecs by Chrome.

Thanks @monyone for the quick reply.

I can confirm it does work as expected in Safari on Mac OS. Editing the README could save a lot of confusion :)

Is it something that could be supported in other browser in the future or it's very unlikely? Why Edge and Safari? Because they are native to the OS?

jamesst20 avatar Oct 15 '24 02:10 jamesst20