xpublish icon indicating copy to clipboard operation
xpublish copied to clipboard

convert filters to jsonify for zarr

Open kthyng opened this issue 2 years ago • 7 comments

  • included a new test for this that fails without the new behavior

This PR closes https://github.com/xpublish-community/xpublish/issues/223

kthyng avatar Aug 17 '23 17:08 kthyng

It looks like this run was canceled, not that it failed. Is that right?

kthyng avatar Aug 18 '23 21:08 kthyng

Ya, not sure what that was about. I'll see if I can restart it.

abkfenris avatar Aug 18 '23 22:08 abkfenris

Hmm, all the jobs ended early again. Two again are marked as failed but show canceled, and the rest are canceled. Not sure what's going on with that.

abkfenris avatar Aug 18 '23 22:08 abkfenris

I can run py.test locally and have it pass, but I can't test against the whole matrix while I'm on plane wifi.

abkfenris avatar Aug 18 '23 22:08 abkfenris

You need to add a fail-fast: false to force everything to run. Otherwise GHA will cancel all tests as soon as the first one fails.

ocefpaf avatar Aug 19 '23 12:08 ocefpaf

@abkfenris Should I make that change to the github workflow in this PR?

kthyng avatar Aug 21 '23 21:08 kthyng

Ya, we can try that, but I'm not certain that it will actually fix the underlying issue. I tried running things again yesterday and it still is showing two jobs as failed, but the logs of all jobs say canceled.

https://github.com/xpublish-community/xpublish/actions/runs/5894225786?pr=225 image

It sounds like there may be some resource contention issues, though we've had the same workflow run successfully on other PRs.

I can sometimes get a single job to pass https://github.com/xpublish-community/xpublish/actions/runs/5894225786/job/16109245196?pr=225

abkfenris avatar Aug 22 '23 15:08 abkfenris