xperseguers
Error makeInstance PageInformationFactory during Login at Typo3 v13
The Error has been fixed here, but the code is not present in the current 4.0.1 release nor in the main branch. See here vs. here
If I add it manually, the error is gone.
@SomeBdyElse maybe this is interesting for you too, since you wrote #205 back then.
So #205 introduces the bug fixed by #201 for v13. If there is no solution for both TYPO3 versions, wouldn't be the best way to release a separate extension version for v13?
@siwa-ddiesenreither We need to find out why the PageInformationFactory service is not made public by our Services.yaml. I'm in touch with Stefan regarding this, see also https://github.com/xperseguers/t3ext-oidc/issues/197#issuecomment-2824281681
I finally tested this partially on my own.
- I used latest v13 and installed the extension.
- I added the OIDC Plugin to a page
- I added
$pageInformationFactory = GeneralUtility::makeInstance(PageInformationFactory::class);as the first line within https://github.com/xperseguers/t3ext-oidc/blob/master/Classes/Controller/LoginController.php#L66
=> No error whatsoever. Instantiation worked flawlessly.
I fail to understand why this should fail within https://github.com/xperseguers/t3ext-oidc/blob/master/Classes/Service/AuthenticationService.php#L700
@foliengriller @siwa-ddiesenreither Are you really using latest master of this extension within v13?
I have tested again with the current Master (installed via composer) and TYPO3 13.4.19 - same error. It fails directly with the error from above.
@foliengriller I now did a quick upgrade of an v12 instance to v13, that already used oidc-master-branch. I tested and debugged the whole login process. I simply fail to reproduce this issue. The class is simply there.
I fear, that's all I can do for now. It must be something in your instance that is different with autoloading/DI.