t3ext-ig_ldap_sso_auth icon indicating copy to clipboard operation
t3ext-ig_ldap_sso_auth copied to clipboard

[WISH] Upgrade for TYPO3v12 compatibility

Open ByteBandito opened this issue 2 years ago • 14 comments

Just wishing this extension for TYPO3v12.

Thanks for the great extension! Patrick

ByteBandito avatar Mar 03 '23 15:03 ByteBandito

Hi ! Any news about v12 compatibility ?

CIMEOS avatar Apr 04 '23 15:04 CIMEOS

No, It is still not updated :-(.

ByteBandito avatar Apr 14 '23 11:04 ByteBandito

(mistake - did not want to close the issue)

ByteBandito avatar Apr 14 '23 11:04 ByteBandito

Hi, this extension will ultimately get compatibility for v12, naturally, but not having any project "near v11" right now and much to do in the next few months, I don't plan to work on it for fun.

Best to help here would first to try it under v12 and see what actually breaks...

xperseguers avatar Apr 18 '23 14:04 xperseguers

It breaks completly :-). When installed, the backend is just empty. Nothing. Frontend the same.

I need to remove it by editing the PackageStates.php manually and removing it.

No entry in error-log.

ByteBandito avatar Apr 18 '23 14:04 ByteBandito

This is most likely due to the constant "TYPO3_MODE" being removed. Do a full search+replace of "TYPO3_MODE" with "TYPO3" in the code, that should at least get the backend/frontend rolling again.

The extension itself has a few things to migrate; the typo3scan utility helps to identify:

  • Deprecation of ObjectManager
  • andX/orX removal of DB layer
  • Severity of FlashMessages
  • Extbase Controller Context deprecation
  • Deprecated TemplateService
  • Changes in error logger
  • Merger of salted passwords
  • Changes to getting bootstrap instance
  • Direct access of extConf

All these things should fall into a "doable, but cumbersome and worth effort" category. But I doubt that the extension will run much further with the initial patch above...

I've bookmarked this to look into if I catch some spare time and do a contribution, but please don't hold your breath (last time I used this extension was in the v9 days, so I'm lacking a bit experience)

garvinhicking avatar Apr 19 '23 13:04 garvinhicking

Hi... any news on this?? :'-(

ByteBandito avatar Jun 20 '23 09:06 ByteBandito

@ByteBandito you may have a look at https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/pull/174 but as written there, the PR won't be merged as-is as it unfortunately doesn't respect the spirit of the extension being compatible for 2 LTS and I have no spare time to work on it right now.

xperseguers avatar Jun 21 '23 08:06 xperseguers

Hey does anyone have this extension ready for 12? We can sponsor it

agendartobias avatar Oct 06 '23 11:10 agendartobias

Hi, I'm also looking for a TYPO3 12 version of ig_ldap_sso_auth.

the PR won't be merged as-is as it unfortunately doesn't respect the spirit of the extension being compatible for 2 LTS and I have no spare time to work on it right now.

Maybe it is time to break up with this requirement? TYPO3 v12 brought so many changes, especially in the Backend (JS modules, Ckeditor, ModuleRegistration, etc.) that I've also decided for my own extensions to drop the support of several LTS versions, because of too much efforts.

Better to have a TYPO3 12 only version, rather than no working version, I guess?

a-r-m-i-n avatar Dec 08 '23 10:12 a-r-m-i-n

Just as an idea:

You could support v12 and forward-support v13 already (by not using deprecated functions in v12), keeping the "2 releases spirit" but avoiding the hassle of keeping if/else switches to cope with the amount of changes brought by the v12 release.

Having a legacy v11/v10 branch for patches and fixes for the old release is still possible.

baschny avatar Feb 02 '24 17:02 baschny

+1

Better to have a TYPO3 12 only version, rather than no working version, I guess?

Yes, much better! This is the only extension that prevents us from updating to 12 and we cannot drop it. :-/

h-e-l-l-o-w-o-r-l-d avatar Feb 28 '24 10:02 h-e-l-l-o-w-o-r-l-d

From what I read here, nobody knows if and when this extension will be available for typo3 12? A statement from the developers about when you can expect the extension for v12 or whether it needs support - be it financial or through man power - would be really great and would make planning for upcoming updates to 12 easier.

LightsOnDeveloper avatar Mar 15 '24 10:03 LightsOnDeveloper

As already written by @mschwemer:

There is a fork at https://github.com/DMKEBUSINESSGMBH/t3ext-ig_ldap_sso_auth/

We use this already in several production environments.

https://github.com/xperseguers/t3ext-ig_ldap_sso_auth/pull/174#issuecomment-1954183741

julianhofmann avatar Mar 15 '24 11:03 julianhofmann