xpdanet.github.io icon indicating copy to clipboard operation
xpdanet.github.io copied to clipboard

Add Flutter Desktop (when ready)

Open TheJaredWilcurt opened this issue 4 years ago • 0 comments

Tool Name: Flutter Desktop

Link to the tool website:

  • https://github.com/flutter/flutter/wiki/Desktop-shells

  • https://flutter.dev/desktop

  • [x] This tool supports creating desktop apps on more than one desktop operating system (Windows, Linux, OSX)

Anything else you want to add:

  • Flutter is a Dart based Cross-platform mobile tool from Google that acts as a Material Design UI toolkit. They have plans to expand into Desktop (currently only support Chromebooks via Chromebooks supporting Android apps).
  • The docs mention that this is all very early currently and all API's will change drastically before first release.

OS: Win, OSX, Lin

Lang: Dart

Pros: *

Cons: *

TheJaredWilcurt avatar Oct 14 '19 15:10 TheJaredWilcurt

Hey. Can I work on this??

ghost avatar Oct 01 '20 10:10 ghost

@shubhamgoyall yes absolutely. Help is highly appreciated.

weisJ avatar Oct 01 '20 10:10 weisJ

if there are 2 files.....save16.png and save24.png. They will be replaced by only one file...save.svg right??

ghost avatar Oct 01 '20 12:10 ghost

@shubhamgoyall Yes those files will be replaced by one file.

weisJ avatar Oct 01 '20 12:10 weisJ

@shubhamgoyall you still working on this?

markolo25 avatar Oct 02 '20 00:10 markolo25

@shubhamgoyall you still working on this?

no..i unassigned myself

ghost avatar Oct 02 '20 02:10 ghost

@markolo25 are you still working on this? If you are, what's the status?

marko-radosavljevic avatar Oct 07 '20 12:10 marko-radosavljevic

@marko-radosavljevic will work on it friday night, work's been pretty busy, and haven't had time, feel free to unassign so someone else can pick it up before friday.

markolo25 avatar Oct 07 '20 16:10 markolo25

@marko-radosavljevic it seems @weisJ has already made progress on this should we assign it to him instead.

markolo25 avatar Oct 07 '20 21:10 markolo25

@markolo25 My PR is only to allow incremental work on the icons. Instead of merging some icons into dev they will first be merged into #60. Then if all icons are complete those can be merged together into the main branch. The only icon I have added is the project logo :D

weisJ avatar Oct 07 '20 21:10 weisJ

thanks for the clarification, so workflow wise, i should fork #60 then create PR against #60? then once we're done we create a PR for #60 against dev?

markolo25 avatar Oct 08 '20 01:10 markolo25

I think #60 source branch should be on this repo, not in the fork. This is more confusing I believe, so lets wait for @weisJ to confirm if this is intentional or not ^^

marko-radosavljevic avatar Oct 08 '20 03:10 marko-radosavljevic

I didn't realize I pushed the branch to the wrong repo. I made a new PR (#64) with the branch on this repo.

weisJ avatar Oct 08 '20 07:10 weisJ

Some icons have more than 1 variant. For instance edit-redo and redo. Is there any point in having different icons in cases like this? Could we just use the same redo icon for both situations? [edit] another example is application_osx_terminal and utilities-terminal.

alehel avatar Oct 10 '20 15:10 alehel

No there is no point in having different icons. One variant is enough.

weisJ avatar Oct 10 '20 15:10 weisJ

How is GitHubs support for squashing a PR upon merge? Let's say we have a total of 10 PRs which merge icons into the main convert to svg branch. Could we then easily squash all these commits into one single commit against dev?

alehel avatar Oct 10 '20 15:10 alehel

Yes github allows for squash merge.

weisJ avatar Oct 10 '20 15:10 weisJ

Tiny problem with the the underline icon. Intellij doesn't seem to have one. They have icons for bold and italic. Anyone know where we can find one for underline which would fit in with the ones intellij provides for bold and italic?

alehel avatar Oct 10 '20 16:10 alehel

I think there is an icon an A in intelliJ. We could shrink that one and add a plain rectangular line under it. i.e. AllIcons.Actions.MatchCaseHovered maybe using just the small a as it gives us more play with the icon positioning.

See guidelines for icon design here

weisJ avatar Oct 10 '20 17:10 weisJ

I always thought a U with a line under it was synonymous with underline, but this perhaps varies based on region?

alehel avatar Oct 10 '20 17:10 alehel

You are right. There is an "u" in CidrLangIcons.Icons.FileTypes.Cuh alternatively If this doesn't look good a small u could be fabricated out of one of the various small "m" in the icons. There might also be a small "u" somewhere. I only skimmed over the list.

weisJ avatar Oct 10 '20 17:10 weisJ

I'll look into it. Hopefully I can finish another 20 tomorrow evening.

alehel avatar Oct 10 '20 17:10 alehel

I have updated the list of missing icons in the PR (#64).

weisJ avatar Oct 10 '20 21:10 weisJ

Do we want a new netbeans logo? It's mentioned in the list. However, I assume it was mentioned because Netbeans was used to develop the program originally. As we are moving away form using Netbeans for the gui, do we still need this icon?

I also see the list mention an icon called icon. This is the O from the original logo. What do we want to replace this with?

alehel avatar Oct 11 '20 10:10 alehel

Do we want a new netbeans logo? It's mentioned in the list. However, I assume it was mentioned because Netbeans was used to develop the program originally. As we are moving away form using Netbeans for the gui, do we still need this icon?

No we won’t need won’t a NetBeans logo.

I also see the list mention an icon called icon. This is the O from the original logo. What do we want to replace this with?

We should try to create a simplified version of our new logo which is suitable to be used as a smaller logo. But for now the new logo can be used instead.

weisJ avatar Oct 11 '20 10:10 weisJ

Anyone know what the zip icon is used for? I have a feeling not many people even know what a zip disc is any more 😂.

alehel avatar Oct 11 '20 11:10 alehel

The icons isn't actually used anywhere. At least I couldn't find any reference to it in the code.

weisJ avatar Oct 11 '20 12:10 weisJ

Well that certainly makes it easier.

alehel avatar Oct 11 '20 12:10 alehel

We have three flags that need icons (US, DE and ES). Been looking around for good candidates. I figured it was important we took them from a place that has a complete collection so that we can easily get new flags for other countries and still have them look consistent. I found this repo which has SVGs of flags for 249 countries. They originate from Wikimedia Commons. https://github.com/emcrisostomo/flags

The three flags are here: https://github.com/emcrisostomo/flags/blob/master/svg/DE.svg https://github.com/emcrisostomo/flags/blob/master/svg/ES.svg https://github.com/emcrisostomo/flags/blob/master/svg/US.svg

Does this look like a good source for country icons?

alehel avatar Oct 22 '20 05:10 alehel

Looks like a good source to me. It would be good though to have all icons be the same aspect ration (e.g. through a square size). Otherwise we would need to hardcode the sizes for each icon separately when loading them.

weisJ avatar Oct 22 '20 10:10 weisJ