spot icon indicating copy to clipboard operation
spot copied to clipboard

Feature / Fix?: Follow the system theme

Open ctsk opened this issue 3 years ago • 3 comments

Summary

The theme preference is now represented by an enum with 3 values:

  • light => maps to libadwaita::ColorScheme::ForceLight The app uses the light theme - regardless of system prefs

  • dark => maps to libadwaita::ColorScheme::ForceDark The app uses the dark theme - regardless of system prefs

  • system => maps to libadwaita::ColorScheme::Default The Apps style follows the system theme preferences

Result

image

ctsk avatar Sep 14 '22 13:09 ctsk

I set the default to following the system theme.

ctsk avatar Sep 14 '22 13:09 ctsk

You should run cargo fmt before comitting to fix those pipeline errors :)

Diegovsky avatar Sep 16 '22 20:09 Diegovsky

LGTM on the whole. I wonder if @xou816 had a reason to make it the way it currently is.

IMO it looks better to have a "theme" property than a "prefers-dark" for clarity.

Diegovsky avatar Sep 16 '22 20:09 Diegovsky

thanks for the review Diegovsky :) and thanks for the contribution ctsk! let's rebase and see how the ci goes

xou816 avatar Feb 12 '23 22:02 xou816

looks like it works perfectly, thanks for your patience!! merging

xou816 avatar Feb 12 '23 22:02 xou816