spot icon indicating copy to clipboard operation
spot copied to clipboard

Feature request: option to follow system theme

Open pesader opened this issue 2 years ago • 4 comments

Hi! Would it be possible to add a "Follow system theme" option to the settings? It could change the gsettings prefers-dark-theme to false, as you mentioned here.

I got that Spot stays dark intentionally, but I'd love to have light/dark consistency especially now that Dark Mode is officially a thing on GNOME 42. Take a look, I think it makes Spot feel even more "at home" on GNOME:

Light Dark
image image

Thanks a lot for developing Spot!!

pesader avatar May 01 '22 20:05 pesader

I was about to comment you can toggle that on Preferences but it did not work for me lol

Diegovsky avatar May 05 '22 11:05 Diegovsky

I was about to comment you can toggle that on Preferences but it did not work for me lol

Same here on Pop!_OS 22.04 (using Light theme) / Flatpak 0.3.3 - when I set the Theme to 'Dark' in the preferences, it does not change to dark. I'm guessing this a bug?

iGadget avatar Aug 08 '22 10:08 iGadget

Must be. If I have the time I'll open a pull request. It might take a while so if you know rust, feel free to open a pull request

Diegovsky avatar Aug 08 '22 14:08 Diegovsky

I had a go at it in #548

I still don't know why ColorScheme::PreferDark / ColorScheme::PreferLight do not respect system settings, but apparently ColorScheme::Default does.

The PR also changes the theme menu to have 3 options - Force Light theme, Force Dark theme, Follow System theme.

Let me know your thoughts!

ctsk avatar Sep 14 '22 13:09 ctsk

fixed by #548

xou816 avatar Feb 18 '23 15:02 xou816