spot
spot copied to clipboard
xou816
Albums with multiple discs are unclear
Describe the bug Some albums have multiple discs. For these albums, the track number jumps back to 1 in the middle of the album when a new disc starts.
To Reproduce Steps to reproduce the behavior:
- Go to any album with multiple discs (for example: Portal 2: Songs to Test By)
- Scroll down to the first track on the second disc
Expected behavior Spot should somehow show where a new disc starts. Maybe something like the way Spotify does it? (see screenshots)
Screenshots
Current behavior:
How it's done on Spotify:
General information:
- Distribution: Arch
- Installation method: Flathub
- Version: 0.3.1
- Device used: Desktop
Not very trivial technically I'm afraid - ListViews don't allow headers in between a list like that.
Not very trivial technically I'm afraid - ListViews don't allow headers in between a list like that.
Maybe have two list views with a GtkLabel or something like that? I'm not too familiar with the codebase, but I feel like that could work.
Maybe have two list views with a GtkLabel or something like that? I'm not too familiar with the codebase, but I feel like that could work.
No - listviews have to be the sole child of a scrollable and can't have stuff like headers 'in the way', so to speak, unfortunately
We can try to do what Gnome Settings does with its separate sections in one page
Edit: grammar
We can try to do what Gnome Settings does with its separate sections in one page
No we can't - completely different widgetry.
So I did some search and it seems we can use AdwPreferencesGroup outside of a preferences page.
If it's not a good idea, maybe we could use AdwActionRow as a separator instead, or we could separate every disc in a AdwExpanderRow. What do you think?
Again - completely different widgetry. Preferences* use ListBoxes - which are less scalable but are more flexible, which works great for a couple preferences. We use ListViews for playlists, which are more scalable (so that playlists and albums with >N tracks don't just break apart), but that adds restrictions: we have to have the playlist as the sole child of a scrolling view, so we can't have headers.
I've heard something about sections for ListViews being implemented, which might work in this case, but I do not know much more about that.
Sorry, I totally mixed them up. Thank you for the explanation though.
Yeah, implementing sections for ListViews would be awesome for this, but we'll have to wait unfortunately
@Diegovsky sorry I don't have a lot of time anymore and I haven't worked with GTK in quite awhile. Wish I could've been of assistance.
It's cool, I don't have the time to do it either unfortunately :)
Anyhow, if anyone wants to work on this I would be glad to mentor.