react-native-material-ui icon indicating copy to clipboard operation
react-native-material-ui copied to clipboard

Published 20 hours ago • verified publisher icon xotahal

Menu not working on ios

Open nsantini opened this issue 7 years ago • 16 comments

The Toolbar menu (as seen in the demo app) works on Android but not on IOS

screen shot 2016-10-25 at 11 07 37 am

nsantini avatar Oct 24 '16 22:10 nsantini

Thank you @nsantini for report ..

xotahal avatar Oct 25 '16 16:10 xotahal

Any progress on this issue?

nicolasbrugneaux avatar Mar 31 '17 15:03 nicolasbrugneaux

Any idea when or if this feature is coming? would prefer not to get into custom modal code :)

shkyang avatar Sep 07 '17 20:09 shkyang

Perhaps implementing this function on iOS as a no-op would be a good interim solution? It would stop the app from crashing. Thoughts?

ctgardner avatar Sep 30 '17 04:09 ctgardner

Why don't you use this internally?

react-native-material-menu

Anyway, as workaround, anyone can use it as rightElement of the toolbar and get the menu working

FezVrasta avatar Dec 02 '17 16:12 FezVrasta

any updates on this issue? :)

mezod avatar Apr 02 '18 17:04 mezod

@xotahal On iOS, we could use ActionSheetIOS to show native iOS menu. What do you think? https://facebook.github.io/react-native/docs/actionsheetios.html

janziemba avatar Apr 17 '18 07:04 janziemba

Hey, any updates?

Gazfay avatar Jun 22 '18 11:06 Gazfay

@janziemba It probably doesn't generate material design menu, does it? Anyway, there is probably no need to wrap RN's action sheet to our Menu component. If someone wants to use these Action Sheets it is easier to use it directly from RN ... At least I think :) We should rather fix this issue ...

xotahal avatar Jun 22 '18 11:06 xotahal

Yes i can use custom component, but i need ability to set options menu, because i use search toolbar and this toolbar render search icon as last item on the right side and only "menu" prop can render some icon buttons as last item. I'm waiting for fix.

Gazfay avatar Jun 26 '18 08:06 Gazfay

@xotahal Looks like what Google Drive and Docs do is similar to the ActionSheetIOS popup but in a different style.

I'm willing to help work on a fix for this issue.

jextrevor avatar Aug 10 '18 01:08 jextrevor

Honestly, I agree with @FezVrasta's solution, the menu library there is more "material" looking than the default Android menu anyway

jextrevor avatar Aug 10 '18 04:08 jextrevor

I've created a working version of react-native-material-menu integrated into react-native-material-ui, using the existing syntax for RightElement. You can view it on my fork. If the authors of this project feel it is good enough, I will make a pull request.

jextrevor avatar Aug 11 '18 22:08 jextrevor

Hi, Any update on this issue?

senthilmca90 avatar Mar 07 '19 12:03 senthilmca90

+1

joaodematejr avatar Mar 08 '19 21:03 joaodematejr

I've opened up a pull request that updates the project to use react-native-material-menu.

jextrevor avatar Mar 08 '19 23:03 jextrevor