react-native-material-ui icon indicating copy to clipboard operation
react-native-material-ui copied to clipboard

Missing Tabs component

Open argosk opened this issue 8 years ago • 12 comments

First of all a big thanks for this amazing project. I'm going to use it for my next app but I see that missing the Tabs component It would be nice to have this component, any plans?

argosk avatar Oct 14 '16 14:10 argosk

Interesting idea. I'm not sure if it's just about style. Do you want to make a pull request? ;)

xotahal avatar Oct 15 '16 05:10 xotahal

It would be interesting to have this

Philip-Nunoo avatar Nov 24 '16 03:11 Philip-Nunoo

I'm going to need this in a few days. I'm going to study the material design guideline and try to implement it and send a PR. Any directions, @xotahal ?

sabbaticaldev avatar Nov 30 '16 22:11 sabbaticaldev

Great @meiraleal 👍 Just try to follow style of another components. There always have to be style prop which have a container. Then there have to be getStyles method that counting the style for a component. And of course - eslint.

Think it won't be hard to implement this component without animation. Animations will be harder. And then it should have some events like - onTabChange, etc.

xotahal avatar Dec 01 '16 08:12 xotahal

Hey @meiraleal, I've just realized I've implemented bottom navigation. I try to make new component here for this bottom navigation and then it probably will be only about position and background color. What do you mean?

This is the result: screen shot 2016-12-02 at 10 23 09 am

xotahal avatar Dec 02 '16 09:12 xotahal

I think its good, @xotahal! Are you handling the panels (content) with this component? I'd implement it without content handling, just the events, like onTabChange, and the user handle it.

sabbaticaldev avatar Dec 02 '16 21:12 sabbaticaldev

Yeah, it's the question. For this bottom navigation is ok without handling the content. But for the tab navigation - everyone needs to handle animation to work with "changing" the content due to the tab underline. If you understand me ... We will see, we can do it without handling the content and in the feature we can improve it ;)

xotahal avatar Dec 03 '16 10:12 xotahal

@xotahal Why don't you integrate with react-native-scrollable-tab-view? It deals with animation already. I'm currently working on it actually. I can make a pull request if it fits with this library.

simsim0709 avatar Mar 06 '17 08:03 simsim0709

@simsim0709 I don't think we need it here. This library is just about styles/material design. And I think your library is more about navigation.

For example, I use BottomNavigation component from this library as a custom tabBarComponent in react-navigation. And it works in the same way how your react-native-scrollable-tab-view works. You know what I mean, don't you?

xotahal avatar Mar 06 '17 10:03 xotahal

@xotahal Yep. I get it :)

simsim0709 avatar Mar 07 '17 01:03 simsim0709

I agree that those header tabs would be nice. How about implementing this component into the project somehow?

Jarrio avatar Mar 15 '17 05:03 Jarrio

Any updates regarding this issue ? I still cant implement Tabs from this library.

AleksandarSimikic avatar Feb 13 '20 09:02 AleksandarSimikic