fcatalog_client icon indicating copy to clipboard operation
fcatalog_client copied to clipboard

Published 20 hours ago • verified publisher icon xorpd

Update to the 7.x API

Open peterjmorgan opened this issue 6 years ago • 4 comments

The 7.x API changed how add_menu_item works. Is there a plan to update fcatalog_client to the new API?

peterjmorgan avatar Apr 24 '18 00:04 peterjmorgan

Hi Peter. I actually want to do this, but I remember having some problems porting some stuff, I just can't remember where I had the problems.

The way I understand it, the two files that need to be ported are:

  • fcatalog_plugin.py
  • fcatalog_client/ida_client.py

I think that the bigger porting issues are actually in fcatalog_client/ida_client.py. I am also not sure yet how to make this change so that both users of IDA6 and IDA7 can keep using fcatalog_client.

I will be more than happy to get some help/ideas about this.

xorpd avatar Apr 24 '18 17:04 xorpd

https://github.com/LightningBladeXYZ/fcatalog_client/commits/master Not sure if it works, and the code does not look great. To make it IDA6 & IDA7 compatible you'll need if idaapi.IDA_SDK_VERSION < 700

sven337 avatar Jun 18 '18 17:06 sven337

@sven337 : Your contribution is highly appreciated! I hope to have time soon to read your code and do the relevant porting to IDA7. I also noticed that you mentioned connection problems. I will take a look into that too.

xorpd avatar Jun 19 '18 16:06 xorpd

This is NOT my code. I only found it. I can confirm that it works on IDA 7 without any changes.

sven337 avatar Jun 19 '18 16:06 sven337