docker-telegram icon indicating copy to clipboard operation
docker-telegram copied to clipboard

Retrieve latest Telegram version during build

Open findesgh opened this issue 3 years ago • 4 comments

Wouldn't it make more sense to retrieve the latest version number of telegram during build, i.e. in the Dockerfile, instead of the update script? I prefer to build the container locally and this would make things much more convenient for me. Maybe I'm missing a good argument against it though?

findesgh avatar Feb 10 '22 17:02 findesgh

We'll it is perfectly doable but it is more convenient for me as that script creates a tag in the repository. Which cannot be done at build time. But this script can evolve as well as the dockerfile to ease local build.

xorilog avatar Feb 10 '22 18:02 xorilog

I see, that makes sense, of course. I'll see if I can come up with something that satisfies both requirements.

findesgh avatar Feb 19 '22 15:02 findesgh

I've solved this for myself by adding some very simple argument handling to the update script with a -bo/--build-only option, which limits what the script does to the local build. Default behavior is as now. Happy to create a PR if you believe this could be useful, but be warned: it's not very sophisticated :-).

findesgh avatar Jun 16 '22 15:06 findesgh

Otherwise feel free to close ;-).

findesgh avatar Jul 08 '22 19:07 findesgh

after some time, you finally get what you wanted ! i hope it fit your need well :)

xorilog avatar Jan 26 '23 12:01 xorilog