markdig icon indicating copy to clipboard operation
markdig copied to clipboard

MediaLinks Extension doesn't work on relative links

Open RickStrahl opened this issue 2 years ago • 4 comments

It appears that the .UseMediaLinks() extension does not detect media when the URL is not an http link, but rather a relative path.

The following demonstrates:

image

Note that the only media link created correctly is the one that has the full HTTP link while the relative link/no path ones render as images which is not correct.

Here's a Gist with the above code: https://gist.github.com/RickStrahl/36035c87787fc24e37861059e40a6f8b

RickStrahl avatar Jun 13 '23 00:06 RickStrahl

For reference here's a screen shot of Markdown Monster rendering the above links as well as a relative image and an explicit HTML video tag:

image

For the markdown media links only the online https:// links work.

However the manual video link work fine with a relative path for image rendered out of the current path (cut off bottom image is a video player instance).

RickStrahl avatar Jun 13 '23 01:06 RickStrahl

Medialinks extension only supports absolute URL. It could support relative with an option to allow them. I don't have time to implement such feature but PR welcome if someone is looking for this.

xoofx avatar Jul 08 '23 16:07 xoofx

Do you think relative paths need an option? Seems like this should just work otherwise it's confusing why some media links work and some do not.

Looks like the only other parser that actually supports media link parsing (on Babelmark) is PanDoc. PanDoc turns relative paths into respective <video> and <audio> links along with fully qualified Urls.

If I find some time I'll take a look.

RickStrahl avatar Jul 08 '23 17:07 RickStrahl

Do you think relative paths need an option? Seems like this should just work otherwise it's confusing why some media links work and some do not.

Problem is more backward compatibility that could start to break existing code that were relying on this behavior.

xoofx avatar Jul 08 '23 17:07 xoofx