UnityNuGet icon indicating copy to clipboard operation
UnityNuGet copied to clipboard

Add Microsoft.EntityFrameworkCore 3.1.X

Open IvanMurzak opened this issue 3 years ago • 6 comments

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • [X] Add a link to the NuGet package:
  • https://www.nuget.org/packages/Castle.Core/4.4.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/3.1.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Abstractions/3.1.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Analyzers/3.1.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Proxies/3.1.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Relational/3.1.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Sqlite/3.1.0
  • https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.Sqlite.Core/3.1.0
  • [X] It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • [X] It must provide .NETStandard2.0 assemblies as part of its package
  • [X] The lowest version added must be the lowest .NETStandard2.0 version available
  • [X] The package has been tested with the Unity editor
  • [X] The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • [X] All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

Hello @xoofx ,

Understanding UnityNuGet

Should I just modify registry.json ?

Dependency issue

I am trying to upload EntityFrameworkCore to UnityNuGet. Had misunderstanding. Need your suggestion. The Microsoft.EntityFrameworkCore 3.1.25 has Microsoft.EntityFrameworkCore.Analyzers in it's own dependencies list. But for some reason the dependency is optional, and for some reason, the dependency even doesn't work with Unity. Instead if to remove it manually that is fine. Standalone works pretty fine.

IvanMurzak avatar Jun 05 '22 21:06 IvanMurzak

@xoofx missed dependency had been added. Hope now the test will be succeded.

IvanMurzak avatar Jun 22 '22 15:06 IvanMurzak

Hey @xoofx, could you please run one more validation?

IvanMurzak avatar Jul 04 '22 21:07 IvanMurzak

Local tests are all green image

IvanMurzak avatar Aug 08 '22 21:08 IvanMurzak

Don't merge it yet. I found an issue. These packages are missed for some reason.

IvanMurzak avatar Aug 09 '22 10:08 IvanMurzak

@xoofx I need help, can't figure it out. Is it normal if my packages have a "missing" status in logs?

IvanMurzak avatar Aug 18 '22 23:08 IvanMurzak

@xoofx it needs your attention. Is it normal that in logs some packages (even not mine) have a "missing" status? If so - looks like everything is good to launch

IvanMurzak avatar Sep 14 '22 10:09 IvanMurzak

@xoofx please merge it finally.

IvanMurzak avatar Nov 10 '22 14:11 IvanMurzak