NESM icon indicating copy to clipboard operation
NESM copied to clipboard

Published 20 hours ago • verified publisher icon xomachine

Fix #17

Open zintrepid opened this issue 3 years ago • 3 comments

Use uncheckedAssign for object variant assignment

zintrepid avatar Feb 09 '22 09:02 zintrepid

This change or a similar one is what I expect is needed, but it does not actually fix issue #17 until nim-lang/NIM#19266 is fixed. Also, there is some code duplication that I don't like, but I don't know a way to avoid it.

zintrepid avatar Feb 09 '22 09:02 zintrepid

I just want to update here that until https://github.com/nim-lang/Nim/issues/19266 is fixed, this is untestable. I'm not 100% sure this is the entire fix, either. Perhaps a PR is premature or it could be left open until it can be verified.

zintrepid avatar Feb 11 '22 06:02 zintrepid

OK. I will keep an eye on the related PR in Nim

xomachine avatar Feb 11 '22 15:02 xomachine