xod icon indicating copy to clipboard operation
xod copied to clipboard

Can’t bind values to constants while editing xod/core

Open nkrkv opened this issue 8 years ago • 5 comments

Steps to reproduce

  1. Open a patch in xod/core project
  2. Place a xod/core/constant-number node
  3. Try to bind a value

Expected behavior

  • I can enter the value on VAL output via Inspector

Actual behavior

  • The field is disabled saying “defined by input”

nkrkv avatar Nov 15 '17 13:11 nkrkv

I can't reproduce it(both in the released version and most recent master), and we already have a check for this case: https://github.com/xodio/xod/blob/6d0266f836074f88f4f359bd403b2a08763d7b67/packages/xod-project/src/patch.js#L268-L280

But it does reproduce when xod/core as opened as a project, and constant nodes have type @/constant-number instead of xod/core/constant-number.

evgenykochetkov avatar Nov 16 '17 13:11 evgenykochetkov

@evgenykochetkov Ah, I see. I think it’s a ~bug~ flaw anyway but given it appears only in a rudimental case, it is not a regression, nor urgent. Thank you.

Let it brew on the backlog.

nkrkv avatar Nov 16 '17 13:11 nkrkv

@nkrkv I reproduced this bug. And I think this is urgent and regression 😬 It occurred when I test wave nodes and tried to set T for all nodes by bind some value to the constant-number. I tested them in the separate project (not inside xod/core).

brusherru avatar Nov 16 '17 17:11 brusherru

:open_mouth: I’m at 6d0266f836074f88f4f359bd403b2a08763d7b67 and can’t reproduce the bug in welcome-to-xod. @brusherru Can you spot the exact step-by-step scenario? Commit SHA you’re on will also help.

nkrkv avatar Nov 17 '17 08:11 nkrkv

Here is a minimal example to reproduce the issue @brusherru is talking about: https://gist.github.com/evgenykochetkov/ce828868a657f7bfd529631a96f88cac

But that is another issue, not the one described here.

EDIT: addressed in #893

evgenykochetkov avatar Nov 17 '17 09:11 evgenykochetkov