simple-ddl-parser icon indicating copy to clipboard operation
simple-ddl-parser copied to clipboard

Published 20 hours ago • verified publisher icon xnuinside

Please, remove "print" calls from library code

Open ivbeg opened this issue 2 years ago • 1 comments

Describe the bug Using 'print' is a bad practice for code debuging. Please remove print from output/common.py and dialects/snowflake.py. Better use logging module.

To Reproduce Steps to reproduce the behavior:

  1. Use simple-ddl-parser from any command like script

Expected behavior Replace 'print' with 'logging.info' or 'logging.debug'. Avoid using 'print' in library code

ivbeg avatar Jul 01 '22 08:07 ivbeg

initially was using print, because library expected only work as a console utility or script, but yes, make sense change to logging

xnuinside avatar Jul 01 '22 08:07 xnuinside

@ivbeg done in release 0.28.0 I will close this issue

xnuinside avatar Oct 31 '22 10:10 xnuinside