Marcus Asteborg

Results 172 comments of Marcus Asteborg

I do think we are missing a timeout, in the case when signaling is setup but for some reason the stun packets are not reaching the str0m instance. Str0m will...

> > I do think we are missing a timeout, in the case when signaling is setup but for some reason the stun packets are not reaching the str0m instance....

maybe something like? ``` cmake if(NOT OPUS_FIXED_POINT) add_sources_group(opus silk ${silk_sources_float_avx2}) endif() ```

maybe worth a simple end2end tests

related: https://issues.webrtc.org/issues/42226301 Need to find CL that is tied to it.

I saw this as well. I didn't write this code, but we should compare what autoconf does and mimic that.

We only use direct API, but if I remember correctly, it will fire for local added streams.

> We only use direct API, but if I remember correctly, it will fire for local added streams. I did verify that when we add our local streams with direct...

> [@xnorpx](https://github.com/xnorpx) > > > I did verify that when we add our local streams with direct API we are getting MediaAdded events. > > Wonder if this was with...

I wonder if the estimate then should indicate approximate rtp header overhead per mid, so a user can simply subtract it depending on it's allocation scheme. (For audio rtp overhead...