xmtpd icon indicating copy to clipboard operation
xmtpd copied to clipboard

Enable network CLI command has to be re-entrant

Open mkysel opened this issue 8 months ago • 2 comments

If I call add-node-to-network on a node that has already been added to the network, the command should succeed and return 0. Possibly the same for remove/disable

$ docker logs libxmtp-enable-node-1
{"level":"INFO","time":"2025-04-03T16:15:30.539Z","caller":"NodeRegistryAdmin","message":"node added to canonical network","node_id":100}
{"level":"FATAL","time":"2025-04-03T16:16:10.901Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}
{"level":"FATAL","time":"2025-04-03T16:16:11.240Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}
{"level":"FATAL","time":"2025-04-03T16:16:11.717Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}
{"level":"FATAL","time":"2025-04-03T16:16:12.382Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}
{"level":"FATAL","time":"2025-04-03T16:16:13.440Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}
{"level":"FATAL","time":"2025-04-03T16:16:15.314Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}
{"level":"FATAL","time":"2025-04-03T16:16:18.800Z","message":"could not add node to network","error":"execution reverted: custom error 0x4992486d: FailedToAddNodeToCanonicalNetwork()"}

mkysel avatar Apr 03 '25 16:04 mkysel

dunno if this is done. I will leave the decision to @fbac

mkysel avatar Apr 14 '25 16:04 mkysel

This still needs some changes in the NodeRegistry.

fbac avatar Apr 22 '25 09:04 fbac