xmlunit.net icon indicating copy to clipboard operation
xmlunit.net copied to clipboard

Support for NUnit4

Open drjameshouse opened this issue 1 year ago • 1 comments

When updating to use NUnit 4.0.1 the following exception occurs: System.TypeLoadException : Method 'get_Description' in type 'Org.XmlUnit.Constraints.CompareConstraint' from assembly 'xmlunit-nunit3-constraints, Version=2.9.2.240, Culture=neutral, PublicKeyToken=e7d7e3088fd452f6' does not have an implementation.

NUnit4 requires constraints to have a Description getter.

drjameshouse avatar Jan 25 '24 20:01 drjameshouse

I haven't even been aware there is an NUnit 4.x, yet. Thanks for the heads up. This should probably be listed as breaking change over at nunit.org.

bodewig avatar Jan 26 '24 07:01 bodewig

From what I understand, in NUnit3 it was a virtual property and now it is abstract. Can we just declare an override for the virtual Description property so that it will be compatible with NUnit4?

mingyaulee avatar Aug 07 '24 09:08 mingyaulee

sorry, I've pushed #41 to a branch a while ago and was distracted by the CI failing again, which ha become a real nuisance. Yes I believe that's all that is required, I'll try to push out a new release soonish.

bodewig avatar Aug 07 '24 15:08 bodewig

I've just published 2.10.0

bodewig avatar Aug 08 '24 19:08 bodewig