react-native-line icon indicating copy to clipboard operation
react-native-line copied to clipboard

upgrade ios sdk to 5.8.1/android sdk to 5.7.0

Open blackbing opened this issue 2 years ago • 14 comments

upgrade ios sdk to 5.8.1/android sdk to 5.7.0

🔄 Type of change:

  • [x] ✨Feature/chore
  • [ ] :recycle: Refactor
  • [ ] :wrench: Bugfixes

:pencil2: Description:

The library SK is out of date. There are newer version to upgrade. Besides,

IOS

we don't need use_frameworks! if react-native >= 0.63.

Android

the namespace was changed. com.linecorp:linesdk -> com.linecorp.linesdk:linesdk:


:pushpin: Notes:

  • for anyone who need to use the latest SDK directly, feel free to use our repo
yarn add verybuy/react-native-line#8dcc99d

because we don't have publish permission @xmartlabs/react-native-line, so we build the dist and push to our repo.

You can also checkout the commit. https://github.com/VeryBuy/react-native-line/commits/feature/verybuy


:heavy_check_mark:Tasks:

  • we have integrated in our project and it works.

blackbing avatar May 16 '22 04:05 blackbing

Have a good day, great to see your hard work! I'm currently doing Line Authentication in my React-Native App, and I can not find any good Repo like yours. But I still not implement right in IOS:D Can you make a doc/tutorial on using your repo. Thank you very much.

dienhungptit avatar May 17 '22 08:05 dienhungptit

@dienhungptit I updated the README. please checkout the diff

https://github.com/xmartlabs/react-native-line/pull/90/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

blackbing avatar May 17 '22 10:05 blackbing

Tks pro.

dienhungptit avatar May 18 '22 10:05 dienhungptit

@blackbing error when build android

* What went wrong:
Execution failed for task ':xmartlabs_react-native-line:compileDebugKotlin'.
> Compilation error. See log for more details

how to work on Android and iOS I using react 18.2.0 and react-native 0.69.1

phuocantd avatar Jul 20 '22 04:07 phuocantd

@blackbing error when build android

* What went wrong:
Execution failed for task ':xmartlabs_react-native-line:compileDebugKotlin'.
> Compilation error. See log for more details

how to work on Android and iOS I using react 18.2.0 and react-native 0.69.1

Do you install our fork repo?

yarn add verybuy/react-native-line#8dcc99d

blackbing avatar Jul 20 '22 05:07 blackbing

@blackbing I install yarn add @xmartlabs/react-native-line@VeryBuy/react-native-line#feat/upgrade-sdk

phuocantd avatar Jul 20 '22 06:07 phuocantd

Have you done Android setup? https://github.com/VeryBuy/react-native-line/tree/feat/upgrade-sdk#android-setup

blackbing avatar Jul 20 '22 06:07 blackbing

Have you done Android setup? https://github.com/VeryBuy/react-native-line/tree/feat/upgrade-sdk#android-setup

@blackbing work on iOS when downgrade react-native version 0.67.2 but Android I setup follow you but open popup then display error

phuocantd avatar Jul 20 '22 07:07 phuocantd

@blackbing you can check in this repo https://github.com/phuocantd/RNLine

phuocantd avatar Jul 20 '22 07:07 phuocantd

@blackbing I found the cause, because it doesn't match the package name. I hope you will update for react native version 0.69 soon

phuocantd avatar Jul 20 '22 07:07 phuocantd

I see. Our project use [email protected]. when we upgrade to 0.69 above, I will take a look the problem. I think it might do some migrate task like this. https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

blackbing avatar Jul 20 '22 08:07 blackbing

from ver0.68 file AppDelegate.m convert to AppDelegate.mm

phuocantd avatar Jul 20 '22 08:07 phuocantd

@phuocantd i have error on Android "xmartlabs_react-native-line:compileDebugKotlin". How to fix it

VanDinh18 avatar Aug 24 '22 02:08 VanDinh18

@phuocantd i have error on Android "xmartlabs_react-native-line:compileDebugKotlin". How to fix it

what's version react native you use?

phuocantd avatar Aug 24 '22 02:08 phuocantd