Eureka icon indicating copy to clipboard operation
Eureka copied to clipboard

InlineRow Alignment off on Xr and Xs Max

Open caffeineflo opened this issue 5 years ago • 3 comments

Latest Eureka Version, iOS 12.2 Affected devices Xr and Xs Max

Screenshot might not be optimal, I apologize for that.

The issue is that all rows are usually 8pt leading, InlineRows such as DateInlineRow are not somehow. In my screenshot the selected cell is a TextRow while the rows underneath are DateInlineRows. The TextRow aligns with all others but not the InlineRows.

CustomConstraints is not available on InlineRows, hence the issue here to find a proper solution.

Screen Shot 2019-04-29 at 10 54 26

caffeineflo avatar Apr 29 '19 15:04 caffeineflo

Hi @caffeineflo, does this happen only on iPhone XR and XS Max? Not on iPhone X, for example? Also, what happens if you put a DateRow next to a DateInlineRow, are they aligned?

mats-claassen avatar May 06 '19 13:05 mats-claassen

It does not happen on a iPhone X, only XR and XS Max.

A DateRow next to a DateInlineRow are aligned.

caffeineflo avatar May 07 '19 17:05 caffeineflo

So the issue seems to be that the default margins for those iPhones is different than the margins for the previous iPhones and that some rows have custom constraints based on those margins while others use the textLabel which is managed by iOS and has no constraints

mats-claassen avatar May 10 '19 13:05 mats-claassen