xmake-repo icon indicating copy to clipboard operation
xmake-repo copied to clipboard

Add workflow v0.11.9.

Open Barenboim opened this issue 5 months ago • 19 comments

麻烦 @waruqi 合并一下这个。

Barenboim avatar Jun 24 '25 07:06 Barenboim

为啥test都失败呢。

Barenboim avatar Jun 24 '25 07:06 Barenboim

Bot detected the issue body's language is not English, translate it automatically.


Why did the test fail?

Issues-translate-bot avatar Jun 24 '25 07:06 Issues-translate-bot

不要一下子改这么多版本,和同时改两个包

确保一个包一个 pr ,最小改动,一次更新一个版本,否则 ci跪了 都没法调

waruqi avatar Jun 24 '25 16:06 waruqi

Bot detected the issue body's language is not English, translate it automatically.


Don't change so many versions at once, and change two packages at the same time

Make sure to package one pr one by one, with minimum changes and update one version at a time, otherwise you can't adjust it even if you are kneeling down.

Issues-translate-bot avatar Jun 24 '25 16:06 Issues-translate-bot

为啥test都失败呢。

根据错误修,报错都很明显,自身 cmakelists 写的有问题。。

https://github.com/sogou/workflow/blob/76d2698cfaf1d8fa00a0b5aaf14a6a50d3bad575/CMakeLists_Headers.txt#L31

看着新版本根本没支持 windows , 既然不支持 on_install 就把 windows 禁用了

waruqi avatar Jun 24 '25 22:06 waruqi

为啥test都失败呢。

根据错误修,报错都很明显,自身 cmakelists 写的有问题。。

https://github.com/sogou/workflow/blob/76d2698cfaf1d8fa00a0b5aaf14a6a50d3bad575/CMakeLists_Headers.txt#L31

看着新版本根本没支持 windows , 既然不支持 on_install 就把 windows 禁用了

好,我们直接把Windows的去了吧,实在没有办法维护和主版一样的Windows。

Barenboim avatar Jun 25 '25 08:06 Barenboim

为啥test都失败呢。

根据错误修,报错都很明显,自身 cmakelists 写的有问题。。

https://github.com/sogou/workflow/blob/76d2698cfaf1d8fa00a0b5aaf14a6a50d3bad575/CMakeLists_Headers.txt#L31

看着新版本根本没支持 windows , 既然不支持 on_install 就把 windows 禁用了

为啥test都失败呢。

根据错误修,报错都很明显,自身 cmakelists 写的有问题。。

https://github.com/sogou/workflow/blob/76d2698cfaf1d8fa00a0b5aaf14a6a50d3bad575/CMakeLists_Headers.txt#L31

看着新版本根本没支持 windows , 既然不支持 on_install 就把 windows 禁用了

Windows的包不是使用这个CMake,Windows专门打了个tag。另外Unix版的编译用的是xmake,不是cmake。

Barenboim avatar Jun 25 '25 08:06 Barenboim

好的。我这次也是加了一行啊,其实。

我把旧版本删了再试试

------------------ Original ------------------ From: ruki @.> Date: Wed,Jun 25,2025 10:58 PM To: xmake-io/xmake-repo @.> Cc: xiehan @.>, Comment @.> Subject: Re: [xmake-io/xmake-repo] Add workflow v0.11.9. (PR #7479)

@waruqi commented on this pull request.

In packages/w/workflow/xmake.lua: > - add_versions("v0.10.6", "5701ef31518a7927e61b26cd6cc1d699cb43393bf1ffc77fa61e73e64d2dd28e") - add_versions("v0.10.7", "aa9806983f32174597549db4a129e2ee8a3d1f005923fcbb924906bc70c0e123") - add_versions("v0.10.8", "bb5654e8011822d4251a7a433cbe4c5ecfd2c65c8f997a8196685742d24bcaf0") - add_versions("v0.10.9", "10f695aeb5da87ae138e3bcd2fa10c18aac782b0da20f11b2fd0b7b091d06767") - add_versions("v0.11.1", "06968ed4e43f6676811b620d09eb5c32ac57252305e7e28def6efde8ef1ceb19") - add_versions("v0.11.2", "cc2d18ab2b292e2f0163ef67ef6976912e2a21c271396da0e2151ca8cd22abd3") - add_versions("v0.11.3", "af7adcdd8151f8e72247599a43c28aa849d61ed39e58058cfa80649d011575bc") - add_versions("v0.11.4", "844fd03db120141fa61600b26a4ef35716dc0e75d1e8c8018078eb385cf746a4") - end
不要一下子改这么多,这会触发 ci 上 一次测试十多个版本。

你可以先加 0.11.9 其他的都不动,确保仅仅测试 0.11.9

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Barenboim avatar Jun 25 '25 15:06 Barenboim

好的。我这次也是加了一行啊,其实。

目前 ci 的测试脚本是根据 diff 变动来提取版本列表的,你版本号没变,但是动了这一行,也会去测它。

waruqi avatar Jun 25 '25 15:06 waruqi

Bot detected the issue body's language is not English, translate it automatically.


OK. I also added a line this time, actually.

Currently, ci's test script extracts the version list based on the diff change. Your version number has not changed, but if you move this line, you will also test it.

Issues-translate-bot avatar Jun 25 '25 15:06 Issues-translate-bot

似乎没有 static target 被编译,安装后是没有库产生导致,先放着吧,回头我看下

waruqi avatar Jun 26 '25 04:06 waruqi

Bot detected the issue body's language is not English, translate it automatically.


It seems that no static target is compiled, and after installation, no library is generated, so let's leave it first, I'll look back

Issues-translate-bot avatar Jun 26 '25 04:06 Issues-translate-bot

你们的配置比较特殊,static target 里面就一个空壳,都是通过 add_deps + object kind 去引入的。

也许 xmake 3.0 重构后,对这块 case 没怎么处理,导致没有 link 出文件。

waruqi avatar Jun 26 '25 04:06 waruqi

Bot detected the issue body's language is not English, translate it automatically.


Your configuration is quite special. There is only an empty shell in the static target, which is introduced through add_deps + object kind.

Perhaps after xmake 3.0 is refactored, this case is not handled much, resulting in no link to output the file.

Issues-translate-bot avatar Jun 26 '25 04:06 Issues-translate-bot

等下这个 patch https://github.com/xmake-io/xmake/pull/6592

waruqi avatar Jun 27 '25 03:06 waruqi

我修复了,剩下的 你重新改回去 并禁用 windows 就好

waruqi avatar Jun 27 '25 05:06 waruqi

Bot detected the issue body's language is not English, translate it automatically.


I fixed it, just change the rest and disable windows

Issues-translate-bot avatar Jun 27 '25 05:06 Issues-translate-bot

我修复了,剩下的 你重新改回去 并禁用 windows 就好

嗯嗯,感谢作者指导。

Barenboim avatar Jun 27 '25 05:06 Barenboim

Bot detected the issue body's language is not English, translate it automatically.


I fixed it, just change the rest and disable windows

Yes, thanks to the author for guidance.

Issues-translate-bot avatar Jun 27 '25 06:06 Issues-translate-bot