xmake-repo
xmake-repo copied to clipboard
Update sentencepiece to v0.2.0
I decided to remove v0.1.97 because the cmakelists had changed in the meantime, and there were issues with building in shared mode on windows.
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
- 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。
There are some link errors on linux and macos that I don't quite understand. For some platforms/configurations, it's just gperftools, but for others, it's all the dependencies (protobuf, abseil and gperftools). I have checked the link command, and it seems to provide all the necessary links for me.
For the cstdint missing include, I fixed it, but not committed it because I was trying to fix the link errors.
@luadebug I fixed the link error with protobuf by refactoring the protobuf package (PR #7756). Since sentencepiece only needs to link on protobuf lite, how to use only protobuf lite component in a package ? In a target it's add_packages("sfml", {components = "graphics") but what about in a package?
Some builds are still failing because of another link error this time with gperftools.
@luadebug I fixed the link error with protobuf by refactoring the protobuf package (PR #7756). Since sentencepiece only needs to link on protobuf lite, how to use only protobuf lite component in a package ? In a target it's
add_packages("sfml", {components = "graphics")but what about in a package?Some builds are still failing because of another link error this time with gperftools.
I saw that it is in TODO maybe I think so... https://github.com/xmake-io/xmake/blob/dev/xmake/modules/private/utils/package.lua#L21 You could try enforce gperftools configs to {shared = true}?