gotp icon indicating copy to clipboard operation
gotp copied to clipboard

Published 20 hours ago • verified publisher icon xlzd

'@' Symbol

Open rhysjtevans opened this issue 1 year ago • 3 comments

https://github.com/xlzd/gotp/blob/fab697c03c2c75f423710795f6b00b53c6c5442f/utils.go#L42

Hi, I've stumbled on your library and like it! While I was testing I noticed this. Most accounts are linked to email addresses that obviously include '@' symbol. Any reason why we are URL Escaping the account?

Problem is when passing the URI to a QR code generator the email is translated to ....%40domain.com

rhysjtevans avatar Jul 20 '22 20:07 rhysjtevans

Temporarily getting round this via a text replace on the string before passing it to the QR Code generator but would be nice if you removed this

rhysjtevans avatar Jul 20 '22 20:07 rhysjtevans

Hi, in official docs label should be URI encoded, but not URL.

mergenchik avatar Aug 06 '22 11:08 mergenchik

@rhysjtevans can you please check and confirm that current issue is fixed

mergenchik avatar Aug 06 '22 11:08 mergenchik

Closing this issue

mergenchik avatar Aug 17 '22 08:08 mergenchik