Xline icon indicating copy to clipboard operation
Xline copied to clipboard

refactor(client)!: Remove request wrappers - WatchClient::watch

Open lxl66566 opened this issue 1 year ago • 2 comments

Depends-On: #905

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

    • use enum WatchKeyOptions to record with_prefix and with_from_key because when constructing WatchRequest, the key is not given.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

lxl66566 avatar Jul 19 '24 11:07 lxl66566

@lxl66566 Convert your pr to draft since CI failed

mergify[bot] avatar Jul 19 '24 11:07 mergify[bot]

Codecov Report

Attention: Patch coverage is 80.58252% with 20 lines in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (e35b35a) to head (aa3a08e). Report is 171 commits behind head on master.

Files Patch % Lines
crates/xlinectl/src/command/watch.rs 72.22% 10 Missing :warning:
crates/xline-client/src/types/range_end.rs 86.66% 2 Missing and 2 partials :warning:
crates/xline-client/src/types/watch.rs 86.36% 2 Missing and 1 partial :warning:
crates/xline/src/server/lock_server.rs 0.00% 2 Missing :warning:
crates/xline-client/src/clients/lock.rs 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   75.55%   76.15%   +0.60%     
==========================================
  Files         180      190      +10     
  Lines       26938    28880    +1942     
  Branches    26938    28880    +1942     
==========================================
+ Hits        20353    21995    +1642     
- Misses       5366     5549     +183     
- Partials     1219     1336     +117     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 19 '24 11:07 codecov[bot]

@lxl66566 Convert your pr to draft since CI failed

mergify[bot] avatar Jul 21 '24 11:07 mergify[bot]

@lxl66566 Your PR is in conflict and cannot be merged.

mergify[bot] avatar Jul 29 '24 03:07 mergify[bot]