refactor(client)!: Remove request wrappers - WatchClient::watch
Depends-On: #905
Please briefly answer these questions:
-
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
-
what changes does this pull request make?
- use
enum WatchKeyOptionsto recordwith_prefixandwith_from_keybecause when constructingWatchRequest, the key is not given.
- use
-
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
@lxl66566 Convert your pr to draft since CI failed
Codecov Report
Attention: Patch coverage is 80.58252% with 20 lines in your changes missing coverage. Please review.
Project coverage is 76.15%. Comparing base (
e35b35a) to head (aa3a08e). Report is 171 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 75.55% 76.15% +0.60%
==========================================
Files 180 190 +10
Lines 26938 28880 +1942
Branches 26938 28880 +1942
==========================================
+ Hits 20353 21995 +1642
- Misses 5366 5549 +183
- Partials 1219 1336 +117
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lxl66566 Convert your pr to draft since CI failed
@lxl66566 Your PR is in conflict and cannot be merged.