Xline icon indicating copy to clipboard operation
Xline copied to clipboard

refactor(client)!: Remove request wrappers - AuthClient::role_grant_permission

Open lxl66566 opened this issue 1 year ago • 2 comments

Depends-On: #882

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

lxl66566 avatar Jul 18 '24 00:07 lxl66566

Codecov Report

Attention: Patch coverage is 89.04110% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.21%. Comparing base (e35b35a) to head (a98d199). Report is 187 commits behind head on master.

Files Patch % Lines
crates/xlinectl/src/command/role/grant_perm.rs 79.31% 6 Missing :warning:
crates/xline-client/src/types/auth.rs 92.59% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   75.55%   76.21%   +0.65%     
==========================================
  Files         180      190      +10     
  Lines       26938    28829    +1891     
  Branches    26938    28829    +1891     
==========================================
+ Hits        20353    21972    +1619     
- Misses       5366     5540     +174     
- Partials     1219     1317      +98     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 18 '24 00:07 codecov[bot]

@lxl66566 Your PR is in conflict and cannot be merged.

mergify[bot] avatar Jul 18 '24 09:07 mergify[bot]