Xline icon indicating copy to clipboard operation
Xline copied to clipboard

refactor: implement xline conflict pools

Open bsbds opened this issue 10 months ago • 2 comments

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

    This PR implements the conflict pool data structures in xline.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

bsbds avatar Apr 09 '24 04:04 bsbds

Codecov Report

Attention: Patch coverage is 85.46099% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 75.57%. Comparing base (e35b35a) to head (0ab29e9). Report is 35 commits behind head on master.

Files Patch % Lines
crates/curp/src/server/conflict/test_pools.rs 0.00% 53 Missing :warning:
crates/xline/src/conflict/uncommitted_pool.rs 92.25% 5 Missing and 7 partials :warning:
crates/xline/src/conflict/spec_pool.rs 91.20% 3 Missing and 5 partials :warning:
crates/xline/src/conflict/tests.rs 97.35% 0 Missing and 6 partials :warning:
crates/xline/src/conflict/mod.rs 90.90% 1 Missing and 1 partial :warning:
crates/xlineapi/src/command.rs 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   75.55%   75.57%   +0.02%     
==========================================
  Files         180      187       +7     
  Lines       26938    27563     +625     
  Branches    26938    27563     +625     
==========================================
+ Hits        20353    20831     +478     
- Misses       5366     5450      +84     
- Partials     1219     1282      +63     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 09 '24 04:04 codecov[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 25 '24 02:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 25 '24 02:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 25 '24 02:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 25 '24 14:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 25 '24 14:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]