Xline icon indicating copy to clipboard operation
Xline copied to clipboard

refactor: switch wal to sync implementation

Open bsbds opened this issue 11 months ago • 4 comments

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Switch the curp WAL to synchronous implementation, as the current async version is slow in benchmarks.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

bsbds avatar Mar 19 '24 02:03 bsbds

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 01:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 25 '24 00:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 25 '24 15:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 28 '24 12:04 mergify[bot]

@Mergifyio rebase --autosquash

Phoenix500526 avatar Apr 28 '24 12:04 Phoenix500526

rebase --autosquash

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 28 '24 12:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar May 09 '24 08:05 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar May 09 '24 08:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 77.67857% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 75.62%. Comparing base (e35b35a) to head (4eed780). Report is 61 commits behind head on master.

Files Patch % Lines
crates/curp/src/server/storage/wal/segment.rs 68.25% 7 Missing and 13 partials :warning:
crates/curp/src/server/storage/wal/codec.rs 88.09% 3 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
+ Coverage   75.55%   75.62%   +0.06%     
==========================================
  Files         180      187       +7     
  Lines       26938    27441     +503     
  Branches    26938    27441     +503     
==========================================
+ Hits        20353    20752     +399     
- Misses       5366     5419      +53     
- Partials     1219     1270      +51     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 09:05 codecov[bot]