Xline icon indicating copy to clipboard operation
Xline copied to clipboard

feat: implement rocks transaction

Open bsbds opened this issue 11 months ago • 3 comments

Depends-On: #674

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Implement txn API for rocksdb engine.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

bsbds avatar Mar 18 '24 02:03 bsbds

Codecov Report

Attention: Patch coverage is 23.44828% with 111 lines in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (e35b35a) to head (80e3aeb). Report is 121 commits behind head on master.

Files Patch % Lines
crates/engine/src/rocksdb_engine/transaction.rs 20.74% 107 Missing :warning:
crates/engine/src/memory_engine/transaction.rs 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   75.55%   75.39%   -0.16%     
==========================================
  Files         180      187       +7     
  Lines       26938    27960    +1022     
  Branches    26938    27960    +1022     
==========================================
+ Hits        20353    21081     +728     
- Misses       5366     5590     +224     
- Partials     1219     1289      +70     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 18 '24 02:03 codecov[bot]

@bsbds Your PR is in conflict and cannot be merged.

mergify[bot] avatar Apr 18 '24 06:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 22 '24 07:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 25 '24 15:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 26 '24 02:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar May 06 '24 01:05 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Jun 11 '24 10:06 mergify[bot]

Please squash the commits

Phoenix500526 avatar Jun 17 '24 01:06 Phoenix500526