Xline
Xline copied to clipboard
feat: implement rocks transaction
Depends-On: #674
Please briefly answer these questions:
-
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Implement txn API for rocksdb engine.
-
what changes does this pull request make?
-
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
Codecov Report
Attention: Patch coverage is 15.96244%
with 179 lines
in your changes are missing coverage. Please review.
Project coverage is 75.11%. Comparing base (
e35b35a
) to head (44a5319
). Report is 49 commits behind head on master.
:exclamation: Current head 44a5319 differs from pull request most recent head 7e010f6. Consider uploading reports for the commit 7e010f6 to get more accurate results
Files | Patch % | Lines |
---|---|---|
crates/engine/src/rocksdb_engine/transaction.rs | 15.56% | 175 Missing and 4 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 75.55% 75.11% -0.44%
==========================================
Files 180 187 +7
Lines 26938 27772 +834
Branches 26938 27772 +834
==========================================
+ Hits 20353 20861 +508
- Misses 5366 5630 +264
- Partials 1219 1281 +62
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bsbds Your PR is in conflict and cannot be merged.
@bsbds Convert your pr to draft since CI failed
@Mergifyio rebase
rebase
✅ Branch has been successfully rebased
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed