Xline icon indicating copy to clipboard operation
Xline copied to clipboard

feat: implement curp wal storage

Open bsbds opened this issue 11 months ago • 6 comments

Depends-On: #740

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    This is part of the wal implementation, which implements the WAL storage type

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

bsbds avatar Mar 11 '24 02:03 bsbds

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 18 '24 06:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 09:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 10:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 29 '24 08:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 29 '24 08:04 mergify[bot]

@bsbds Your PR is in conflict and cannot be merged.

mergify[bot] avatar May 09 '24 09:05 mergify[bot]

Codecov Report

Attention: Patch coverage is 80.45977% with 68 lines in your changes missing coverage. Please review.

Project coverage is 75.73%. Comparing base (e35b35a) to head (c92ec80). Report is 132 commits behind head on master.

Files Patch % Lines
crates/curp/src/server/storage/wal/mod.rs 73.41% 20 Missing and 22 partials :warning:
crates/curp/src/server/storage/wal/test_util.rs 71.42% 16 Missing :warning:
crates/curp/src/server/storage/wal/error.rs 0.00% 6 Missing :warning:
crates/curp/src/server/storage/wal/tests.rs 97.39% 3 Missing :warning:
crates/curp/src/server/storage/wal/config.rs 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   75.55%   75.73%   +0.17%     
==========================================
  Files         180      192      +12     
  Lines       26938    28121    +1183     
  Branches    26938    28121    +1183     
==========================================
+ Hits        20353    21297     +944     
- Misses       5366     5506     +140     
- Partials     1219     1318      +99     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 11 '24 02:05 codecov[bot]