Xline icon indicating copy to clipboard operation
Xline copied to clipboard

feat: support redirecting the logs to the terminal

Open GFX9 opened this issue 11 months ago • 2 comments

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) -> Fixes #670 -> Currently, Xline does not support redirecting the logs to the terminal. It outputs to a specified log file through --log-file in command line. If the user does not specify this parameter, the file path /var/log/xline is created by default.

  • what changes does this pull request make? -> Checks whether the user specifies --log-file. If not, output the logs to the terminal and ignore --log-rotate if provided.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc) -> No

GFX9 avatar Mar 11 '24 01:03 GFX9

Codecov Report

Attention: Patch coverage is 63.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 75.76%. Comparing base (e35b35a) to head (57f714f). Report is 115 commits behind head on master.

Files Patch % Lines
crates/xline/src/utils/trace.rs 0.00% 17 Missing :warning:
crates/utils/src/parser.rs 86.48% 4 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   75.55%   75.76%   +0.20%     
==========================================
  Files         180      187       +7     
  Lines       26938    27824     +886     
  Branches    26938    27824     +886     
==========================================
+ Hits        20353    21080     +727     
- Misses       5366     5451      +85     
- Partials     1219     1293      +74     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 11 '24 01:03 codecov[bot]

@GFX9 Convert your pr to draft since CI failed

mergify[bot] avatar Apr 18 '24 06:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 25 '24 15:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]

@GFX9 Convert your pr to draft since CI failed

mergify[bot] avatar Apr 29 '24 06:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 30 '24 14:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 30 '24 14:04 mergify[bot]

@GFX9 Convert your pr to draft since CI failed

mergify[bot] avatar May 01 '24 15:05 mergify[bot]

@GFX9 Convert your pr to draft since CI failed

mergify[bot] avatar May 01 '24 15:05 mergify[bot]

@GFX9 Your PR is in conflict and cannot be merged.

mergify[bot] avatar May 20 '24 01:05 mergify[bot]

@GFX9 Convert your pr to draft since CI failed

mergify[bot] avatar May 27 '24 15:05 mergify[bot]

@GFX9 Convert your pr to draft since CI failed

mergify[bot] avatar Jun 07 '24 07:06 mergify[bot]

@GFX9 Your PR is in conflict and cannot be merged.

mergify[bot] avatar Jun 13 '24 01:06 mergify[bot]