Xline
Xline copied to clipboard
feat: support redirecting the logs to the terminal
-
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) -> Fixes #670 -> Currently, Xline does not support redirecting the logs to the terminal. It outputs to a specified log file through
--log-file
in command line. If the user does not specify this parameter, the file path/var/log/xline
is created by default. -
what changes does this pull request make? -> Checks whether the user specifies
--log-file
. If not, output the logs to the terminal and ignore--log-rotate
if provided. -
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc) -> No
Codecov Report
Attention: Patch coverage is 63.33333%
with 22 lines
in your changes missing coverage. Please review.
Project coverage is 75.76%. Comparing base (
e35b35a
) to head (57f714f
). Report is 115 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
crates/xline/src/utils/trace.rs | 0.00% | 17 Missing :warning: |
crates/utils/src/parser.rs | 86.48% | 4 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 75.55% 75.76% +0.20%
==========================================
Files 180 187 +7
Lines 26938 27824 +886
Branches 26938 27824 +886
==========================================
+ Hits 20353 21080 +727
- Misses 5366 5451 +85
- Partials 1219 1293 +74
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@GFX9 Convert your pr to draft since CI failed
@Mergifyio rebase
rebase
✅ Branch has been successfully rebased
@GFX9 Convert your pr to draft since CI failed
@Mergifyio rebase
rebase
✅ Branch has been successfully rebased
@GFX9 Convert your pr to draft since CI failed
@GFX9 Convert your pr to draft since CI failed
@GFX9 Your PR is in conflict and cannot be merged.
@GFX9 Convert your pr to draft since CI failed
@GFX9 Convert your pr to draft since CI failed
@GFX9 Your PR is in conflict and cannot be merged.