Xline icon indicating copy to clipboard operation
Xline copied to clipboard

Metrics doc

Open iGxnon opened this issue 11 months ago • 3 comments

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
  • Change quick start
  • Fix benchmark
  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

iGxnon avatar Mar 09 '24 12:03 iGxnon

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 75.49%. Comparing base (e35b35a) to head (239b85c). Report is 84 commits behind head on master.

Files Patch % Lines
crates/curp/src/server/metrics.rs 62.50% 12 Missing :warning:
crates/curp/src/server/raw_curp/mod.rs 0.00% 3 Missing :warning:
crates/curp/src/server/curp_node.rs 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   75.55%   75.49%   -0.06%     
==========================================
  Files         180      186       +6     
  Lines       26938    27478     +540     
  Branches    26938    27478     +540     
==========================================
+ Hits        20353    20745     +392     
- Misses       5366     5458      +92     
- Partials     1219     1275      +56     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 09 '24 12:03 codecov[bot]

/cc @bsbds Could you take a look?

iGxnon avatar Mar 19 '24 10:03 iGxnon

@iGxnon Convert your pr to draft since CI failed

mergify[bot] avatar Apr 18 '24 06:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 25 '24 15:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]

@iGxnon Convert your pr to draft since CI failed

mergify[bot] avatar Apr 29 '24 06:04 mergify[bot]

rebased manually

iGxnon avatar May 04 '24 03:05 iGxnon

@iGxnon Your PR is in conflict and cannot be merged.

mergify[bot] avatar May 12 '24 14:05 mergify[bot]