Xline
Xline copied to clipboard
feat: Instrument await using await-tree
-
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) -> FIxes #580 -> Currently, some simple information is logged to display the execution path of the command. This uses more detailed information to show this process (i.e. use await-tree to indicate the duration of each await.).
-
what changes does this pull request make? -> Makes use of instrument_await within functions annotated with the #[instrument] macro to add more detailed async tracing.
-
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc) -> No
Codecov Report
Attention: Patch coverage is 75.71429%
with 17 lines
in your changes are missing coverage. Please review.
Project coverage is 74.59%. Comparing base (
e35b35a
) to head (16ae376
). Report is 70 commits behind head on master.
:exclamation: Current head 16ae376 differs from pull request most recent head 86ea780. Consider uploading reports for the commit 86ea780 to get more accurate results
Files | Patch % | Lines |
---|---|---|
crates/curp/src/server/mod.rs | 69.44% | 9 Missing and 2 partials :warning: |
crates/xline/src/server/kv_server.rs | 33.33% | 5 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
- Coverage 75.55% 74.59% -0.96%
==========================================
Files 180 172 -8
Lines 26938 25342 -1596
Branches 26938 25342 -1596
==========================================
- Hits 20353 18904 -1449
+ Misses 5366 5270 -96
+ Partials 1219 1168 -51
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Will this modification affect performance in any way? I suggest adding a switch here so that we can enable it as needed.
Sure, I'll make the changes and let you know. Thanks!
Can you provide an example after running it?
@Harsh1s Your PR is in conflict and cannot be merged.
Hi, @Harsh1s ! This pr has been stalled for 3 weeks. Would you like to update it? 😄
Hi, @Harsh1s ! This pr has been stalled for 3 weeks. Would you like to update it? 😄
Oh I'm really sorry about the stalling, it's been a busy past month at my uni, a lot of tests and project deadlines. My end semester exams are going on currently too. I'll try to update it within a week for sure. Sorry again!