Xline icon indicating copy to clipboard operation
Xline copied to clipboard

feat: implement WAL segments remover

Open bsbds opened this issue 11 months ago • 5 comments

Depends-on: #705

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Implement WAL segment remover, the segment remover is used to make sure a wal segment file is atomically removed.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

bsbds avatar Mar 08 '24 01:03 bsbds

Rebased on #705

bsbds avatar Mar 22 '24 08:03 bsbds

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 01:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 19 '24 07:04 mergify[bot]

@Mergifyio rebase

Phoenix500526 avatar Apr 25 '24 15:04 Phoenix500526

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Apr 25 '24 15:04 mergify[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 28 '24 12:04 mergify[bot]

Codecov Report

Attention: Patch coverage is 86.86131% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 75.64%. Comparing base (e35b35a) to head (26fdc28). Report is 97 commits behind head on master.

Files Patch % Lines
crates/curp/src/server/storage/wal/remover.rs 86.86% 7 Missing and 11 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   75.55%   75.64%   +0.09%     
==========================================
  Files         180      187       +7     
  Lines       26938    27625     +687     
  Branches    26938    27625     +687     
==========================================
+ Hits        20353    20897     +544     
- Misses       5366     5445      +79     
- Partials     1219     1283      +64     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 29 '24 01:04 codecov[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 30 '24 01:04 mergify[bot]

@bsbds Your PR is in conflict and cannot be merged.

mergify[bot] avatar May 09 '24 09:05 mergify[bot]