Xline icon indicating copy to clipboard operation
Xline copied to clipboard

refactor: enable new sp/ucp implementation

Open bsbds opened this issue 1 year ago • 3 comments

Depends-On: #769

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

bsbds avatar Feb 29 '24 08:02 bsbds

Codecov Report

Attention: Patch coverage is 86.55462% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 75.60%. Comparing base (e35b35a) to head (29695b3). Report is 70 commits behind head on master.

Files Patch % Lines
crates/curp-test-utils/src/test_cmd.rs 0.00% 5 Missing :warning:
crates/xlineapi/src/lib.rs 0.00% 5 Missing :warning:
crates/xlineapi/src/command.rs 0.00% 3 Missing :warning:
crates/curp/src/server/raw_curp/mod.rs 96.00% 2 Missing :warning:
crates/curp/src/server/metrics.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
+ Coverage   75.55%   75.60%   +0.04%     
==========================================
  Files         180      186       +6     
  Lines       26938    27472     +534     
  Branches    26938    27472     +534     
==========================================
+ Hits        20353    20770     +417     
- Misses       5366     5421      +55     
- Partials     1219     1281      +62     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 05 '24 12:03 codecov[bot]

@bsbds Convert your pr to draft since CI failed

mergify[bot] avatar Apr 18 '24 06:04 mergify[bot]

@bsbds Your PR is in conflict and cannot be merged.

mergify[bot] avatar Apr 18 '24 07:04 mergify[bot]