Xline
Xline copied to clipboard
fix: add keep alive logic for xlinectl lock command
Closes: #664
Please briefly answer these questions:
-
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) fix issue #664
-
what changes does this pull request make?
- remove the lease client from LockClient
- add keep alive logic for xlinectl lock cmd
- are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
Codecov Report
Attention: Patch coverage is 16.66667%
with 30 lines
in your changes are missing coverage. Please review.
Project coverage is 75.22%. Comparing base (
e35b35a
) to head (138250e
). Report is 28 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 75.55% 75.22% -0.34%
==========================================
Files 180 182 +2
Lines 26938 26990 +52
Branches 26938 26990 +52
==========================================
- Hits 20353 20302 -51
- Misses 5366 5428 +62
- Partials 1219 1260 +41
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closed since it's duplicated with pr #820