Xline icon indicating copy to clipboard operation
Xline copied to clipboard

fix: fix timeout when append entries

Open iGxnon opened this issue 1 year ago • 3 comments

Signed-off-by: iGxnon [email protected]

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

Fix the lock order

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

No

iGxnon avatar Feb 06 '24 13:02 iGxnon

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (d99ad0c) 74.71% compared to head (03656d4) 74.73%.

Files Patch % Lines
crates/curp/src/server/raw_curp/mod.rs 73.33% 12 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   74.71%   74.73%   +0.01%     
==========================================
  Files         167      167              
  Lines       24159    24167       +8     
  Branches    24159    24167       +8     
==========================================
+ Hits        18051    18060       +9     
+ Misses       4991     4987       -4     
- Partials     1117     1120       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 15:02 codecov[bot]

Please add more details about why the lock order could cause a timeout.

bsbds avatar Feb 29 '24 02:02 bsbds

@iGxnon Your PR is in conflict and cannot be merged.

mergify[bot] avatar Apr 18 '24 06:04 mergify[bot]

Close this PR since it doesn't provide enough information in the description. Additionally, there are no cases to demonstrate that this PR solves any problems.

Phoenix500526 avatar May 14 '24 01:05 Phoenix500526