Xline icon indicating copy to clipboard operation
Xline copied to clipboard

[Refactor]: config

Open themanforfree opened this issue 1 year ago • 7 comments

Now all of our configurations are in a single file, utils/src/config.rs,It also contains a lot of parse_xxx, xxx_format, default_xxx methods, It's messy and difficult to manage. We need to organize these configurations into modules, each containing the configuration itself, its parse method, and default values.

In addition, the configuration can only be created through the new method, which is very inflexible, we need to refactor them use builder pattern, and it should be easy to modify existing configurations

themanforfree avatar Jan 10 '24 05:01 themanforfree

i want to try it

caicancai avatar Feb 02 '24 05:02 caicancai

Due to my personal time constraints, I abandon this issue. I am very sorry.

caicancai avatar Feb 22 '24 10:02 caicancai

Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out!

aryan-errs avatar Feb 26 '24 17:02 aryan-errs

Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out!

This issue has been assigned to you, thank you for your contribution

themanforfree avatar Feb 27 '24 00:02 themanforfree

Hi, I would like to take a look at this issue. Refactoring seems like a good starting to get to understand the codebase.

qstommyshu avatar Feb 29 '24 17:02 qstommyshu

@qstommyshu ,Harsh1s has initiate a pull request to solve this issue,can you try another good-first-issue? Thanks 😄

Phoenix500526 avatar Mar 14 '24 02:03 Phoenix500526