Xline icon indicating copy to clipboard operation
Xline copied to clipboard

[Refactor]: Xline logs

Open bsbds opened this issue 1 year ago • 5 comments

Currently there are serveral issues in the log of Xline:

  1. Log size is huge During a recent Jepsen test with Xline debug level enabled, Xline printed the key-values of every command to logs. This resulted in large log files, as the values can be several tens of kilobytes in size. To address this issue, the logs should be refactored to either use the tracing level or disable the printing of key-values. Note that this issue may also be present in snapshot related logs.

  2. Logs are confusing The current logs are confusing as they lack essential information required for effective debugging. The logs should include key information, such as propose ID and revisions, to enable easy tracking of command execution.

bsbds avatar Nov 10 '23 04:11 bsbds

Refer to https://github.com/xline-kv/Xline/pull/683

Phoenix500526 avatar Mar 11 '24 06:03 Phoenix500526

@bsbds would like to take on this task

rohansx avatar Mar 13 '24 18:03 rohansx

Hi, @rohansx , would you like to take on this issue?

Phoenix500526 avatar Mar 17 '24 02:03 Phoenix500526

@Phoenix500526 Yeah sure i can give it a try

rohansx avatar Mar 17 '24 16:03 rohansx

Hi,@rohansx, I'm glad you're interested in this issue. However, I believe there are some ambiguous points in the issue description, such as how to define the so-called "essential information" in point 2. This may require a deep understanding of the entire project and experience in debugging. IMO, starting with the first point would be relatively easier as a starting point. @bsbds can you give some information for the point two?

Phoenix500526 avatar Mar 22 '24 01:03 Phoenix500526