OpenAgents icon indicating copy to clipboard operation
OpenAgents copied to clipboard

Published 20 hours ago • verified publisher icon xlang-ai

add pdf support

Open freetown113 opened this issue 1 year ago • 7 comments

add minimal necessary logic to support handling of the files in pdf format

freetown113 avatar Nov 29 '23 15:11 freetown113

Nice work, we will go through it very soon!

Timothyxxx avatar Nov 30 '23 01:11 Timothyxxx

Hi, thanks for your great contribution. The code has some circular import issues. I think it is because DocumentSummaryExecutor is imported in document.py but it also imports DocumentDataModel from document.py. Would you mind trying to fix that and testing it on the local host? Thanks.

BlankCheng avatar Dec 02 '23 03:12 BlankCheng

Yes, I shouldn't leave this part of the code in the PR. It was a kind of a draft for the next possible enhancement. I removed it. Please check it now.

freetown113 avatar Dec 04 '23 09:12 freetown113

This PR is stale because it has been open 3 days with no activity.

github-actions[bot] avatar Dec 08 '23 02:12 github-actions[bot]

Hi, I've fixed extra imports to avoid circular imports and added .pdf extension support to let it successfully be run locally. I think it looks good to me overall. However, due to some openai key issue, I cannot test the full functionality as proposed. Would you or other participants be able to local host it and test the pdf functionalities?

BlankCheng avatar Dec 18 '23 05:12 BlankCheng

@freetown113

Timothyxxx avatar Dec 20 '23 11:12 Timothyxxx

This PR is stale because it has been open 3 days with no activity.

github-actions[bot] avatar Dec 24 '23 02:12 github-actions[bot]