treeprint

treeprint copied to clipboard

Wrong call to recursive fn in FindByValue()

1

https://github.com/xlab/treeprint/blob/d235141453da96e0dea798a1ac83b0847159e622/treeprint.go#L118 I think it should be - ``` if v := node.FindByValue(value); v != nil { return v } ```

rskumar

Tests error on 32 bits arches

1

Golang 1.12.6 on i686 and armv7 ``` Testing in: /builddir/build/BUILD/treeprint-a009c3971eca89777614839eb7f69abed3ea3959/_build/src PATH: /builddir/build/BUILD/treeprint-a009c3971eca89777614839eb7f69abed3ea3959/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin GOPATH: /builddir/build/BUILD/treeprint-a009c3971eca89777614839eb7f69abed3ea3959/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/xlab/treeprint/version.commit=a009c3971eca89777614839eb7f69abed3ea3959 -X github.com/xlab/treeprint/version=0 -extldflags '-Wl,-z,relro...

eclipseo

Per-instance settings

1

`EdgeTypeLink`, `EdgeTypeMid`, `EdgeTypeEnd`, and `IndentSize` are global variables. - Related: https://github.com/xlab/treeprint/issues/4 It is not comfortable when one applications depends multiple components which emits tree with different format. I believe it...

apstndb